[OJS] Native Import/Export Plugin v3.2 #2646
Conversation
| $submissions = array(); | ||
| foreach ($submissionIds as $submissionId) { | ||
| $submission = $submissionDao->getById($submissionId, $context->getId()); | ||
| /** @var $submissionService APP\Services\SubmissionService */ | ||
| $submissionService = Services::get('submission'); |
There was a problem hiding this comment.
This removes the check to make sure that the submission is in the right context. I'd love to see this re-added upstream (e.g. in PKPSubmissionService::get) -- ping @NateWr -- but we probably need to talk about standardizing on that post-3.2. For now, please add a check here by hand, e.g.:
if ($submission->getData('contextId') != $context->getId()) continue;
There was a problem hiding this comment.
I'd love to see this re-added upstream
I'd like to avoid this if we can, because it introduces inconsistencies in the EntityReadInterface, but let's chat about this post-3.2.
| // */ | ||
| // function getRepresentationExportFilterGroupName() { | ||
| // return 'article-galley=>native-xml'; | ||
| // } |
| @@ -22,6 +22,8 @@ class AuthorNativeXmlFilter extends PKPAuthorNativeXmlFilter { | |||
| */ | |||
| function __construct($filterGroup) { | |||
| parent::__construct($filterGroup); | |||
|
|
|||
| $this->getNoValidation(true); | |||
There was a problem hiding this comment.
(This is temporary pending tomorrow's work, I think?)
|
|
||
| // Add public ID | ||
| if ($pubId = $issueGalley->getStoredPubId('publisher-id')) { | ||
| $issueGalleyNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'id', htmlspecialchars($pubId, ENT_COMPAT, 'UTF-8'))); |
There was a problem hiding this comment.
I think it's cleaner (and probably safer) to use DOMElement::createTextNode rather than htmlspecialchars to do the escaping. (Here and probably elsewhere)
| @@ -69,7 +108,7 @@ function createCoversNode($filter, $doc, $object) { | |||
|
|
|||
| import('classes.file.PublicFileManager'); | |||
| $publicFileManager = new PublicFileManager(); | |||
| $filePath = $publicFileManager->getContextFilesPath($object->getData('contextId')) . '/' . $coverImage; | |||
There was a problem hiding this comment.
(@NateWr is moving us away from getter functions and towards getData with the introduction of SchemaDAO -- so we may end up changing this back. But for now IssueDAO is not a SchemaDAO, so this is fine, just a heads-up.)
| $publication->setData('sectionId', $section->getId()); | ||
| } | ||
| } | ||
| // check if article is related to an issue, but has no published date |
| $importClass='ArticleGalley'; | ||
| break; | ||
| default: | ||
| $importClass=null; // Suppress scrutinizer warn |
There was a problem hiding this comment.
Wouldn't this be caught by XML validation? If so, there's no need to code for it here. Or it could be an assert, fatalError or Exception if it's a code path that should never run.
| function parseIssueIdentification($publication, $node) { | ||
| $deployment = $this->getDeployment(); | ||
| $context = $deployment->getContext(); | ||
| // $submission = $deployment->getSubmission(); |
| * Constructor | ||
| * @param $filterGroup FilterGroup | ||
| */ | ||
| function __construct($filterGroup) { |
| * Get the method name for inserting a published submission. | ||
| * @return string | ||
| */ | ||
| function getPublishedSubmissionInsertMethod() { |
There was a problem hiding this comment.
Is this function used? I don't see it anywhere (and I think it's the same method name in all apps anyway).
No description provided.