pkp/pkp-lib#282 Dataverse plugin: remove markup from dataset metadata #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1171,7 +1171,7 @@ function createMetadataPackage($article) { | |||
| $package->addMetadata('description', | |||
| $article->getLocalizedData('studyDescription') ? | |||
| $article->getLocalizedData('studyDescription') : | |||
| $article->getLocalizedAbstract() | |||
| String::html2text($article->getLocalizedAbstract()) | |||
There was a problem hiding this comment.
By the way, see http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=9056 -- deposits generally shouldn't be using the getLocalized... functions because those are dependent on the current user's locale, which means a depositor working e.g. in English will deposit different content from someone working e.g. in Spanish.
Better to use, for journal-level content, e.g...
$journal->getLocalizedSetting($journal->getPrimaryLocale())
For article-level content, e.g.:
$article->getTitle($article->getLocale())
There was a problem hiding this comment.
(however, that's a general issue, so I won't hold back on merging this)
Merged
|
Changes made for copyright notice & metadata deposit locale. |
asmecher
added a commit
that referenced
this pull request
Jan 17, 2015
pkp/pkp-lib#282 Dataverse plugin: remove markup from dataset metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some markup accepted in dataset metadata in Dataverse 3, but not in 4.