Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9960 Button to a simplified HTML galley version #4274

Open
wants to merge 2 commits into
base: stable-3_3_0
Choose a base branch
from

Conversation

israelcefrin
Copy link
Contributor

@israelcefrin israelcefrin commented May 13, 2024

This PR adds a button to the HTML file directly in the ToC of the issue and the Article Landing page in OJS 3.3.
It is a solution to the following issue:
pkp/pkp-lib#9960

The solution is a result of a discussion during PKP-Sprint 2024 in Minnesota, OJS Accessibility Group.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ israelcefrin
systems@publicknowledgeproject.org


systems@publicknowledgeproject.org seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@asmecher
Copy link
Member

@israelcefrin, I'm hesitant to add this to 3.3.0 so late in its release cycle, especially since this would add an untranslated locale key for languages other than English.

@israelcefrin
Copy link
Contributor Author

Hey @asmecher , would you rather to add add to OJS 3.4 only? That's fine for me.

@asmecher
Copy link
Member

@israelcefrin, actually, I think this would be best targeted at the main branch (for release in 3.5).

@israelcefrin
Copy link
Contributor Author

@israelcefrin, actually, I think this would be best targeted at the main branch (for release in 3.5).

@asmecher it sounds good to me. Feel free to add it as a milestone to this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants