-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkp/pkp-lib#4787 Reviewer suggestions #4459
Draft
touhidurabir
wants to merge
9
commits into
pkp:main
Choose a base branch
from
touhidurabir:i4787_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
touhidurabir
force-pushed
the
i4787_main
branch
from
October 10, 2024 07:37
42165fe
to
1bd3b67
Compare
touhidurabir
force-pushed
the
i4787_main
branch
from
October 18, 2024 06:21
f99fdd0
to
b167584
Compare
touhidurabir
force-pushed
the
i4787_main
branch
2 times, most recently
from
October 30, 2024 12:28
4786e0b
to
c30ab85
Compare
touhidurabir
force-pushed
the
i4787_main
branch
from
November 3, 2024 04:27
1a222c6
to
4beceee
Compare
touhidurabir
commented
Nov 4, 2024
Comment on lines
+1
to
+23
<?php | ||
|
||
/** | ||
* @file classes/migration/upgrade/v3_5_0/I4787_ReviewSuggestions.php | ||
* | ||
* Copyright (c) 2024 Simon Fraser University | ||
* Copyright (c) 2024 John Willinsky | ||
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING. | ||
* | ||
* @class I4787_ReviewSuggestions.php | ||
* | ||
* @brief Add reviewer suggestion related tables | ||
* | ||
*/ | ||
|
||
namespace APP\migration\upgrade\v3_5_0; | ||
|
||
class I4787_ReviewSuggestions extends \PKP\migration\upgrade\v3_5_0\I4787_ReviewSuggestions | ||
{ | ||
protected string $CONTEXT_TABLE = 'journals'; | ||
protected string $CONTEXT_SETTINGS_TABLE = 'journal_settings'; | ||
protected string $CONTEXT_COLUMN = 'journal_id'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably go to a v3_6_0
folder .
touhidurabir
commented
Nov 4, 2024
@@ -39,6 +39,7 @@ | |||
<migration class="PKP\migration\install\TombstoneMigration" /> | |||
<migration class="PKP\migration\install\DoiMigration" /> | |||
<migration class="PKP\migration\install\InstitutionsMigration" /> | |||
<migration class="PKP\migration\install\ReviewerSuggestionsMigration" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now , this is only a place holder as this should be a part of 3.6.0
upgrade process .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for pkp/pkp-lib#4787