Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OMP] Permit files to be (optionally) associated with chapters #291

Closed
asmecher opened this issue Jan 16, 2015 · 4 comments
Closed

[OMP] Permit files to be (optionally) associated with chapters #291

asmecher opened this issue Jan 16, 2015 · 4 comments
Assignees
@jnugent
Milestone
OMP 1.2

Comments

@asmecher
Copy link
Member

Permit files to be associated with chapters when appropriate. This will help in the presentation of the table of contents, among other things.

This has a rich history -- see http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6190 for example.

More pertinent to Heidelberg's requirements at the moment.
@asmecher asmecher self-assigned this Jan 16, 2015
@asmecher asmecher added this to the OMP 1.2 milestone Jan 16, 2015
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 16, 2015
@asmecher
pkp#291 Permit multiple widgets to coexist on the same page
51a395d
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 16, 2015
@asmecher
pkp#291 Files listbuilders may not need a specific stage ID
7b4e670
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 16, 2015
@asmecher
pkp#291 Make better use of array_key_exists rather than isset
a1b1191
asmecher added a commit to asmecher/pkp-lib that referenced this issue Jan 16, 2015
@asmecher
pkp#291 Permit correct removal of removed additional settings on update
a79d27f
asmecher added a commit to asmecher/omp that referenced this issue Jan 16, 2015
@asmecher
pkp/pkp-lib#291 Add optional chapter association to files
b74d7f4
asmecher added a commit to asmecher/omp that referenced this issue Jan 16, 2015
@asmecher
pkp/pkp-lib#291 Submodule update
2e55f7f
asmecher added a commit to asmecher/omp that referenced this issue Jan 16, 2015
@asmecher
pkp/pkp-lib#291 Submodule update ##asmecher/i291-fix##
061a8dd
@asmecher
Copy link
Member Author

Pulls:
#292
pkp/omp#98

@asmecher asmecher assigned jnugent and unassigned asmecher Jan 16, 2015
@asmecher
Copy link
Member Author

Assigning to you for review, Jason.

jnugent added a commit that referenced this issue Jan 19, 2015
@jnugent
Merge pull request #292 from asmecher/i291-fix
7d3fd3c 
#291 Permit association of files with chapters in OMP
@jnugent
Copy link
Member

jnugent commented Jan 19, 2015

Merged the requests, Alec. Code looks great.

@asmecher
Copy link
Member Author

Thanks, Jason; I have a bit of work to do WRT testing and test data but I'll merge that myself when it's ready.

asmecher added a commit that referenced this issue Jan 20, 2015
@asmecher
#291 Permit chapter/file associations with tests
6df53fd
asmecher added a commit to pkp/omp that referenced this issue Jan 20, 2015
@asmecher
pkp/pkp-lib#291 Permit chapter/file associations with tests
6af5720
asmecher added a commit that referenced this issue Jan 20, 2015
@asmecher
#291 Fix escaping in XPath, which sucks
e47da16
asmecher added a commit to pkp/omp that referenced this issue Jan 20, 2015
@asmecher
pkp/pkp-lib#291 Fix escaping in XPath, which sucks
8d16b87
asmecher added a commit to pkp/omp that referenced this issue Jan 20, 2015
@asmecher
pkp/pkp-lib#291 Test improvements
e73f0a7
asmecher added a commit that referenced this issue Jan 21, 2015
@asmecher
#291 Increase maximum filename length
48f931b
asmecher added a commit to pkp/omp that referenced this issue Jan 21, 2015
@asmecher
pkp/pkp-lib#291 Fix test race condition
63cce94
asmecher added a commit to pkp/omp that referenced this issue Jan 21, 2015
@asmecher
pkp/pkp-lib#291 Submodule update
846837c
asmecher added a commit to pkp/omp that referenced this issue Jan 21, 2015
@asmecher
pkp/pkp-lib#291 Fix test race conditions
13249a5
asmecher added a commit to pkp/omp that referenced this issue Jan 21, 2015
@asmecher
pkp/pkp-lib#291 Fix test race conditions
496ebe7
mtub pushed a commit to mtub/pkp-lib that referenced this issue Jan 24, 2015
@asmecher @mtub
pkp#291 Permit multiple widgets to coexist on the same page
d2856b7
mtub pushed a commit to mtub/pkp-lib that referenced this issue Jan 24, 2015
@asmecher @mtub
pkp#291 Files listbuilders may not need a specific stage ID
a18200b
mtub pushed a commit to mtub/pkp-lib that referenced this issue Jan 24, 2015
@asmecher @mtub
pkp#291 Make better use of array_key_exists rather than isset
f8a596c
mtub pushed a commit to mtub/pkp-lib that referenced this issue Jan 24, 2015
@asmecher @mtub
pkp#291 Permit correct removal of removed additional settings on update
1e58ad1
mtub pushed a commit to mtub/pkp-lib that referenced this issue Jan 24, 2015
@asmecher @mtub
pkp#291 Permit chapter/file associations with tests
0fdf213
mtub pushed a commit to mtub/pkp-lib that referenced this issue Jan 24, 2015
@asmecher @mtub
pkp#291 Fix escaping in XPath, which sucks
7cdde72
mtub pushed a commit to mtub/pkp-lib that referenced this issue Jan 24, 2015
@asmecher @mtub
pkp#291 Increase maximum filename length
26a250f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnugent jnugent

Labels
None yet
Projects
None yet
Milestone
OMP 1.2
Development

No branches or pull requests
2 participants
@asmecher @jnugent