Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OJS] UsageStats Loader doesn't recognize server aliases #299

Closed
ctgraham opened this issue Jan 21, 2015 · 2 comments
Closed

[OJS] UsageStats Loader doesn't recognize server aliases #299

ctgraham opened this issue Jan 21, 2015 · 2 comments
Assignees
@beghelli
Milestone
OJS 2.4.6

Comments

@ctgraham
Copy link
Collaborator

If the log file being ingested contains a DNS name other than what is listed in the base_url, the processing of the line fails silently at https://github.com/pkp/ojs/blob/ojs-dev-2_4/plugins/generic/usageStats/UsageStatsLoader.inc.php#L349

C.f. http://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=13404&p=51618&hilit=base_url#p51615

Proposed solution:
Capture base_url aliases in config.inc.php or site_settings/journal_settings.
@ctgraham
Copy link
Collaborator Author

ctgraham commented Feb 3, 2015

If this is just an issue for the usageStatsLog files (as opposed to Apache logs), the solution might be as simple as forcing UsageEventPlugin::_buildUsageEvent() to normalize the usage_event log output to include the base_url rather than the HTTP_HOST.

@asmecher asmecher added this to the OJS 2.4.6 milestone Feb 3, 2015
beghelli added a commit to pkp/ojs that referenced this issue Feb 24, 2015
@beghelli
pkp/pkp-lib#299 Normalize usage event log urls to avoid server aliases
49cb4ec
beghelli added a commit that referenced this issue Feb 24, 2015
@beghelli
#299 Port normalize usage event url
0e7e51c
beghelli added a commit that referenced this issue Feb 24, 2015
@beghelli
#299 Fix OJS leftovers
5ef7a8b
beghelli added a commit that referenced this issue Feb 24, 2015
@beghelli
#299 Port normalize usage event url
6c05d5f
@beghelli
Copy link
Contributor

Porting done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beghelli beghelli

Labels
None yet
Projects
None yet
Milestone
OJS 2.4.6
Development

No branches or pull requests
3 participants
@asmecher @beghelli @ctgraham