Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyFile method to SubmissionFileManager #3122

Closed
mfelczak opened this issue Nov 28, 2017 · 9 comments
Closed

Add copyFile method to SubmissionFileManager #3122

mfelczak opened this issue Nov 28, 2017 · 9 comments
Milestone

Comments

@mfelczak
Copy link
Member

To support import plugins that need to copy files from the file system.

@mfelczak mfelczak added this to the OJS 3.1.0-1 milestone Nov 28, 2017
mfelczak added a commit to mfelczak/pkp-lib that referenced this issue Nov 28, 2017
asmecher added a commit that referenced this issue Nov 28, 2017
#3122 Add copyFile method to SubmissionFileManager
@NateWr
Copy link
Contributor

NateWr commented Nov 29, 2017

Can this be closed?

@asmecher
Copy link
Member

@NateWr, I left it open to remind myself to warn you about this affecting your near-simultaneous work on uploaderFileIds (bug #3184). Did this change get considered?

@NateWr
Copy link
Contributor

NateWr commented Nov 30, 2017

Nope, I can work on this for #3084. But I wasn't able to find where SubmissionFileManager::copySubmissionFile() is used. Where can I find that to update it?

@asmecher
Copy link
Member

@mfelczak needed it for an import plugin. I'd suggest a quick convo on Slack.

@asmecher
Copy link
Member

Meanwhile, yes, I'll close this!

@NateWr
Copy link
Contributor

NateWr commented Dec 5, 2017

@mfelczak I've got a PR pending that changes the params of this copySubmissionFile method:

0080b11

Once #3084 is merged, you may need to update your plugin where this method is called.

@mfelczak
Copy link
Member Author

mfelczak commented Dec 5, 2017

I've made the change in the plugin, thanks @NateWr!

@mfelczak
Copy link
Member Author

@NateWr, it doesn't look like 0080b11 was ported to ojs-stable-3.1.0 -- any chance we might be able to include this in the upcoming 3.1.1 release?

@asmecher
Copy link
Member

@mfelczak, the OJS 3.1.1 release will come from the master branch, so nothing further is needed. If you want it cherry-picked back to ojs-stable-3_1_0 for hosting reasons, though, that's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants