Privacy consent statements error in registration form multi-journal install

[israelcefrin]

Multi-journal registering form page doesn't allow to proceed with registration since it doesn't display checkbox with privacy consent. That way it always returns a form validation error message.

See how it shows to Portal registering page:
https://demo.publicknowledgeproject.org/pkpschool/ojs3/index.php/index/user/register

And how it is shown in a journal from this Portal:
https://demo.publicknowledgeproject.org/pkpschool/ojs3/index.php/rlr/user/register

[NateWr]

From my memory of previous discussions, we may need:

1. A separate consent statement field in the site settings for site-wide registration.
2. When registering in a multi-journal site, we may need to present the consent statement for each journal a user is registering in, since they may be different.
3. Some multi-journal sites may be able to get by on a single consent statement. Others may need a separate consent statement for each journal. This will usually depend on whether the "host" is a prominent part of a reader's experience with a journal (ie - an institutional publisher) or is in the background (ie - a technical web host or publishing service). For this reason, it might make sense for there to be a config.inc.php option determining whether to enable consent statements on a per-journal basis. When disabled, the site-wide consent statement would be the only thing used in the site or context registrations, and no text field would appear in journal admin areas.

[asmecher]

@NateWr, would you mind taking a crack at this? There's some discussion over at #3870.

[NateWr]

I've implemented the following:

• Added a site-wide privacy statement.
• Added a config option to disable context-specific privacy statements (for sites that only need a single, site-wide statement).
• Added privacy consent checkboxes for site-wide registration. Consent will be requested for a site-wide policy if one exists, and will be requested for any contexts to which a user selects a role and a policy exists.
• If a context has no privacy statement, but the site does, the context's privacy page will display the site-wide privacy statement.

This has implications for existing themes. @Vitaliy-1 would you take a look and update the existing themes as necessary? If you could also provide a PR for the Bootstrap3 theme (https://github.com/NateWr/bootstrap3/issues/93), I'd really appreciate it. Finally, if you're able, it would be good to document this change for third-party themes, and outline steps they need to take to make their themes compatible.

@bozana would you code review?

PRs:
#3964
pkp/orcidProfile#41
pkp/ojs#2086
(No changes required for OMP, since there is no site/context distinction.)

[NateWr]

@asmecher can you code review?

[asmecher]

@NateWr, did you see that the tests failed? OTOH, I suspect it's because you're potentially getting the Site object before the system has been installed (thus no DB).

[NateWr]

Thanks! Think I've fixed it. Tests running.

[NateWr]

@asmecher tests have passed here and I've rebased for a clean merge.

[asmecher]

Reviewed, committed and back-ported to ojs-stable-3_1_1, thanks! I hope we don't have many boilerplate fields with this much of their own baggage, but it makes sense in this case.

[fgnievinski]

the milestone was 3.1.1-4 but it seems that OJS version 3.1.2.0 still gives out this error (user.profile.form.privacyConsentRequired):

maybe there's a regression?

[asmecher]

@fgnievinski, some themes also required adjustment when they overrode affected templates. (See e.g.: NateWr/bootstrap3@0df65c2) What theme are you using?

[fgnievinski]

hi @asmecher , I see the Default theme is selected under Website Settings > Appearance.

There's also a custom journal style sheet that reads simply:

.item.references a {
word-break: break-all;
}

http://www.seer.ufu.br/public/journals/78/styleSheet.css?2019-09-13%2021:18:44

[fgnievinski]

pls let me know if you have any pointers.

I looked in a couple of .less and .tpl files.

thanks

[NateWr]

Look in lib/pkp/templates/frontend/pages/userRegister.tpl. You should see the privacyConstent field there. You may be able to debug by adding some text in there to see if it is showing up (clear template cache under the admin page in the backend whenever you make a change.)