Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

references native import #4195

Closed
bozana opened this issue Oct 29, 2018 · 13 comments
Closed

references native import #4195

bozana opened this issue Oct 29, 2018 · 13 comments
Assignees
@defstat
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone
OJS/OMP/OPS 3.2.0-1

Comments

@bozana
Copy link
Collaborator

bozana commented Oct 29, 2018

provide a possibility (xml element) to import references for a submission
@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Oct 29, 2018
@mtub
Copy link
Member

mtub commented Nov 1, 2018

if you allow references to be imported, people might look for standard bibliographic formats like BibTeX…

@bozana
Copy link
Collaborator Author

bozana commented Nov 2, 2018

Hmmm... yes... but currently OJS does not know about them -- it sees a reference/list of references just as a text...

@eddoff
Copy link
Contributor

eddoff commented Apr 25, 2019

Any development in this issue @bozana ?

I saw that there is a Crossref upload referernce plugin in 3.1.2.0 - that´s great, but this issue to import references to OJS is not fixed...

@diegoabadan
Copy link
Contributor

We are needing this functionality, we should soon send a PR.

ghost pushed a commit to lepidus/ojs that referenced this issue Jan 24, 2020
pkp/pkp-lib#4195 Added article references to XML
666f1ac 
Now each exported article contains the references into node.

Signed-off-by: Leandro <leandro@lepidus.com.br>
Signed-off-by: Lucas Marcos <lucasmarcos@lepidus.com.br>
ghost pushed a commit to lepidus/ojs that referenced this issue Jan 27, 2020
pkp/pkp-lib#4195 Exporting XML with citations.
33560b8 
The citations node creation function now creates a citation node for each reference.
An export example was added to the sample.xml.

Signed-off-by: Leandro <leandro@lepidus.com.br>
Signed-off-by: Lucas Marcos <lucasmarcos@lepidus.com.br>
@diegoabadan diegoabadan mentioned this issue Feb 21, 2020
Open
@diegoabadan
Copy link
Contributor

Hello @asmecher !

Due to the carnival celebrations in Brazil, our team only returns to work on Wednesday afternoon. :(

If you want to see how it looks now:
pkp/ojs@stable-3_1_2...lepidus:i4195-enhancement-import

stable-3_1_2...lepidus:i4195-enhancement-import

We still have to port to 3.2, but I imagine it will be something simple.

We made the changes on top of the stable OJS (3.1.2) to facilitate testing. At first the functionality was implemented, but we will do more tests and check if there was any modification not related to this issue in git.

@asmecher
Copy link
Member

@diegoabadan, I agree that working with stable-3_1_2 is the best thing to do at the moment -- the surrounding code is still getting a little bit of work before the release. (#4880 -- heads-up @defstat!)

@asmecher asmecher mentioned this issue Feb 28, 2020
Closed
@asmecher
Copy link
Member

PRs:

asmecher pushed a commit that referenced this issue Feb 28, 2020
@asmecher
#4195 Changed pkp-native to validate citations assignments
3ba7f61 
Signed-off-by: Leandro <leandro@lepidus.com.br>
Signed-off-by: Lucas Marcos <lucasmarcos@lepidus.com.br>
asmecher pushed a commit that referenced this issue Feb 28, 2020
@JhonathanLepidus @asmecher
Importing XML with citations - Resolves #4195
894f474 
The Submission Filter now has resources to recognize and save the citations from a submission.
You can import an XML sample and visualize the citations.

Signed-off-by: Leandro <leandro@lepidus.com.br>
Signed-off-by: Lucas Marcos <lucasmarcos@lepidus.com.br>
Signed-off-by: Jhonathan Miranda <jhon@lepidus.com.br>
asmecher pushed a commit to pkp/ojs that referenced this issue Feb 28, 2020
@asmecher
pkp/pkp-lib#4195 Added article references to XML
37bee50 
Now each exported article contains the references into node.

Signed-off-by: Leandro <leandro@lepidus.com.br>
Signed-off-by: Lucas Marcos <lucasmarcos@lepidus.com.br>
asmecher pushed a commit to pkp/ojs that referenced this issue Feb 28, 2020
@asmecher
pkp/pkp-lib#4195 Exporting XML with citations.
59a5831 
The citations node creation function now creates a citation node for each reference.
An export example was added to the sample.xml.

Signed-off-by: Leandro <leandro@lepidus.com.br>
Signed-off-by: Lucas Marcos <lucasmarcos@lepidus.com.br>
@asmecher
Copy link
Member

Cherry-picked commits in the above two PRs to stable-3_1_2 -- they now need forward-porting to master.

@asmecher asmecher added this to the OJS/OMP 3.2.1 milestone Feb 29, 2020
@asmecher
Copy link
Member

@defstat, could you forward-port the above two PRs to OJS and OMP master? They didn't make in into 3.2 but they are already in OJS stable-3_1_2.

defstat added a commit to defstat/pkp-lib that referenced this issue Mar 2, 2020
@defstat
pkp#4195 Port Citation import/export to 3.2
58517d0
defstat added a commit to defstat/ojs that referenced this issue Mar 2, 2020
@defstat
pkp/pkp-lib#4195 Port Citation import/export to 3.2
9f47fe6
@defstat
Copy link
Contributor

defstat commented Mar 2, 2020

@asmecher

PRs:
[OJS]: pkp/ojs#2660
[pkp-lib]: #5579

asmecher added a commit that referenced this issue Mar 2, 2020
@asmecher
Merge pull request #5579 from defstat/i4195
71c66fa 
[pkp-lib] #4195 Port Citation import/export to v3.2
asmecher added a commit to pkp/ojs that referenced this issue Mar 2, 2020
@asmecher
Merge pull request #2660 from defstat/pkp/pkp-lib#4195
0fa3870 
[OJS] #4195 Port Citation import/export to v3.2
@asmecher
Copy link
Member

asmecher commented Mar 2, 2020

Merged! Thanks, @defstat.

@asmecher asmecher closed this as completed Mar 2, 2020
@asmecher
Copy link
Member

asmecher commented Mar 2, 2020

Whoops, I closed this too soon, @defstat -- could you also port to OMP master?

@asmecher asmecher reopened this Mar 2, 2020
defstat added a commit to defstat/omp that referenced this issue Mar 2, 2020
@defstat
pkp/pkp-lib#4195 Port Citation import/export to 3.2
ccfd675
@defstat
Copy link
Contributor

defstat commented Mar 2, 2020

@asmecher

PR
[OMP]: pkp/omp#778

asmecher pushed a commit to pkp/omp that referenced this issue Mar 2, 2020
@defstat
[OMP] #4195 Port Citation import/export to v3.2 (#778)
657ee6a 
* pkp/pkp-lib#4195 Port Citation import/export to 3.2

* Submodule update ##defstat/i4195##
@asmecher asmecher closed this as completed Mar 2, 2020
MedAhamada pushed a commit to Maanrifa/ojs that referenced this issue Apr 19, 2020
@defstat @MedAhamada
pkp/pkp-lib#4195 Port Citation import/export to 3.2
a60049d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defstat defstat

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Milestone
OJS/OMP/OPS 3.2.0-1
Development

No branches or pull requests
6 participants
@mtub @asmecher @bozana @defstat @diegoabadan @eddoff