Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJS] datacite export, contributors ORCID iDs not in metadata #4903

Closed
nils-stefan-weiher opened this issue Jul 8, 2019 · 9 comments
Closed
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. Try Me This issue might be good for a new contributor. Can you help us?
Milestone

Comments

@nils-stefan-weiher
Copy link

nils-stefan-weiher commented Jul 8, 2019

Describe the bug
Datacite export XML for any object does not contain the ORCID ids of contributors.

To Reproduce
Check XML output or check registered metadata for the DOI on DataCite DOI Fabrica: https://doi.datacite.org/

What application are you using?
OJS version 3.1.1-4 and above

Additional information
The relevant code for the creating the creator's tag for the Datacite XML is in the function createCreatorsNode in datacite/filter/DataciteXmlFilter.inc.php lines 232 and following:
https://github.com/pkp/ojs/blob/master/plugins/importexport/datacite/filter/DataciteXmlFilter.inc.php#L232-L265

PRs:

@nils-stefan-weiher
Copy link
Author

Example XML for DataCite Schema v4 for creator with ORCID, copied from view-source:https://schema.datacite.org/meta/kernel-4/example/datacite-example-full-v4.xml:

  <creators>
    <creator>
      <creatorName nameType="Personal">Miller, Elizabeth</creatorName>
      <givenName>Elizabeth</givenName>
      <familyName>Miller</familyName>
      <nameIdentifier schemeURI="http://orcid.org/" nameIdentifierScheme="ORCID">0000-0001-5000-0007</nameIdentifier>
      <affiliation>DataCite</affiliation>
    </creator>
  </creators>

@nils-stefan-weiher
Copy link
Author

nils-stefan-weiher commented Nov 25, 2020

It seems in the current state of the master branch ORCID IDs are not yet part of the creator metadate in the plugin XML output.

@asmecher Do you know anyone who could add this? I will probably only have time from next year February after our upgrades to OJS 3.2 are done.

@asmecher
Copy link
Member

@isgrim, it's probably only a couple of lines of code added here: https://github.com/pkp/ojs/blob/stable-3_2_1/plugins/importexport/datacite/filter/DataciteXmlFilter.inc.php#L263..L267
...however, we've got quite a few other priorities to work on. I'll add a "Try Me" tag to this in case it stirs up interest from a potential contributor.

@asmecher asmecher added the Try Me This issue might be good for a new contributor. Can you help us? label Nov 25, 2020
@NateWr NateWr added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Sep 13, 2022
@withanage
Copy link
Member

@nils-stefan-weiher

Did anybody in Heidelberg proceed with this suggestion ?

@nils-stefan-weiher
Copy link
Author

Dear @withanage ,

as far as I know. No, the issue should still exist.

@withanage
Copy link
Member

@nils-stefan-weiher thanks a lot for the update!

@simonevecchi
Copy link

Did anybody proceed with this suggestion ?

@bozana
Copy link
Collaborator

bozana commented Jun 1, 2023

@asmecher, could you take a look at the PR? It also solves/considers this issue: #8865.

@asmecher
Copy link
Member

asmecher commented Jun 1, 2023

Fixed by pkp/ojs#3932, thanks!

@asmecher asmecher closed this as completed Jun 1, 2023
bozana added a commit to bozana/ojs that referenced this issue Jun 2, 2023
bozana added a commit to pkp/ojs that referenced this issue Jun 3, 2023
pkp/pkp-lib#4903 consider creators orcid and affiliation in DataCite …
@bozana bozana modified the milestones: 3.4.0-0, 3.3.0-15 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. Try Me This issue might be good for a new contributor. Can you help us?
Projects
Development

No branches or pull requests

7 participants