Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to see or select publication language after submission #5502

Closed
NateWr opened this issue Feb 11, 2020 · 33 comments
Closed

Not possible to see or select publication language after submission #5502

NateWr opened this issue Feb 11, 2020 · 33 comments
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Milestone

Comments

@NateWr
Copy link
Contributor

NateWr commented Feb 11, 2020

Describe the bug
If a journal allows submissions in more than one language, it's possible to select the language of a submission when making the submission. This is saved to the publication object and effects which locale is required in multilingual form fields. However, once submitted, there's no way to change the publication's locale.

To Reproduce
Steps to reproduce the behavior:

  1. Set up the journal to support more than one language (Settings > Website > Languages) for submissions.
  2. Make a submission and select a language that is not the journal's primary language.
  3. Once the submission is complete, there is no field in the publication forms to change the language.

What application are you using?
OJS/OMP 3.2 (master pre-release)

Additional information
It probably makes the most sense to add a language field to the metadata forms. See #5000 for related work that needs to be done on language metadata.

@NateWr NateWr added this to the OJS/OMP 3.2.1 milestone Feb 11, 2020
@NateWr NateWr added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Feb 11, 2020
@asmecher
Copy link
Member

A potentially tricky UI/UX problem needs solving here. All required submission-level fields must be completed in the submission's primary language, so a change if primary locale when that's not the case would need...

  • to be prevented unless all required fields are completed in the new locale, or
  • to lead the user to a form where these could be completed (though they may currently be fairly far-flung in the UI), or
  • to duplicate data from the old primary locale into the new one (I don't recommend this as it would lead to data poisoning).

@NateWr
Copy link
Contributor Author

NateWr commented Feb 12, 2020

Ok, this makes sense and the first option may be pretty easy to accomplish with the new setup. All edits are run through a validation script which can check for missing data and return an error describing which fields are missing.

I think trying to offer a form is not a good idea, especially now that we have the flexible schema so it's not necessarily very easy to construct such a form.

@pmangahis
Copy link

pmangahis commented Aug 28, 2020

@NateWr @asmecher - Will this allow JM and Editors to see what language the submission was made? We have a multi-lingual client that's accepting submission in 3 languages with no easy way to decern what language the authors have selected in the submission form.

@pmangahis pmangahis added the Hosting Bug reports and feature requests from Publishing Services's hosted clients. label Sep 1, 2020
@NateWr NateWr changed the title Not possible to select publication language after submission Not possible to see or select publication language after submission Sep 7, 2020
@NateWr
Copy link
Contributor Author

NateWr commented Sep 7, 2020

@pmangahis yes, if the UI offered a way to change the language then editors could identify which language it was submitted in. We should try to get this into 3.3 if possible.

@nils-stefan-weiher
Copy link

@asmecher @NateWr Hi Alec and Nate,

is there any status update for this issue?

We have problems with this in combination with the quickSubmit plugin. If you select a submission language in the quickSubmit Plugin and only want to fill the Contributor meta data for this language it is currently not possible, because it seems the Author form is not switched to the new language and the other submission language is marked as required. So you have fill at least two metadata fields.

I thought it would be no problem if we can change the submission language after submiting and correct the contributor metadata after this, but as of now its not possible.

Thanks and regards,

Nils

@nils-stefan-weiher
Copy link

I think I found the issue with the submission language in the quickSubmit Plugin. I opened a separate issue:
#6773

These two issues work together in devious ways 😬

@NateWr
Copy link
Contributor Author

NateWr commented Feb 22, 2021

is there any status update for this issue?

No progress yet, unfortunately!

@fgnievinski
Copy link
Contributor

related (same?) issue in v2:

#742 - Permit editors to change submission locales

@NateWr
Copy link
Contributor Author

NateWr commented Apr 27, 2021

It looks like #742 is filed against OJS 2.x. I've closed that issue because we are not going to put out an update for it.

@librariam
Copy link
Collaborator

+1 from a multilingual journal that uses Quick Submit and currently has no way of correcting the publication locale that was selected by mistake. This affects their metadata export to Coalition Publica that requires the title in the field of that language.

@fgnievinski
Copy link
Contributor

I just wanted to make two suggestions for warning editors about the primary language:

  1. the primary language's status could be emphasized including the text "primary" in brackets, for example, "Português (Brasil) [primary]".

  2. a tooltip message could emphasize its importance:

The primary language's metadata will be used when the article is exported, e.g., for DOI registration and deposit in CrossRef.

Currently the submission's primary language is formatted in bold gray by default:
image

But if you click on a secondary language, we have to language names in bold, the secondary also in color:

image

And you have to click again on the secondary language to unselect it -- maybe clicking on the primary language could do the same?

@nils-stefan-weiher
Copy link

nils-stefan-weiher commented Jun 15, 2023

Still in 3.4.0. this is a major issue for us. We are making preparations to upgrade from 3.1.2 and 3.4.0 with multilingual submissions and we need this option. At least to show the language of the submission.

@nils-stefan-weiher
Copy link

Could you consider increasing the priority? In my opinion its is not a low priority bug, because it means an existing submission can never switch the main language in the current version.

@asmecher
Copy link
Member

@nils-stefan-weiher, can you describe some use cases for this? Why would an author choose the "wrong" primary language, and under what circumstances would someone (author, editor, etc) want to change it?

jyhein added a commit to jyhein/omp that referenced this issue Aug 24, 2023
jyhein added a commit to jyhein/omp that referenced this issue Aug 24, 2023
jyhein added a commit to jyhein/omp that referenced this issue Aug 24, 2023
jyhein added a commit to jyhein/ops that referenced this issue Aug 24, 2023
jyhein added a commit to jyhein/omp that referenced this issue Aug 24, 2023
@jyhein
Copy link
Contributor

jyhein commented Oct 16, 2023

Issue description

If a journal allows submissions in more than one language, it's possible to select the language of a submission when making the submission. This is saved to the submission object and affects which language is required in metadata form fields. However, once submitted, there's no way to change the submission’s/publication's language. The language of the submission is also completely hidden in the UI and can be only guessed by looking at the active metadata fields and content.

Changes

  • In the Submission workflow, add a button next to the 'Activity Log' button. The button shows the current language of the submission. The button opens a modal window. In the modal window, the user can change the language and is informed that the required fields need to be refilled after choosing the submission language. Picture 5 shows the window.
  • Always load the submission metadata forms for the selected submission language.
  • The submission language can be changed when the submission is not published and there is only one version

Questions

Q: We might need to consider moving locale setting from Submission to Publication (discussed with Alec)

The attached PR's includes the following code changes:

  • new form to change submission language; locale, required metadata, and author names are updated
  • e.g. in workflow > publication, submission metadata forms now include submission locale
  • in workflow page, new button to show current submission language and clicking it opens the modal to change language. For author's, only shows language (button diaabled)
  • OJS: new test, changes submission language to French (Canada) and back to English

PRs:
PKP: #9245
UI: pkp/ui-library#280
OJS: pkp/ojs#4016
OMP: pkp/omp#1451
OPS: pkp/ops#563

@asmecher
Copy link
Member

@bozana, again, I think you're already looking at these, but just in case!
Thanks, @jyhein!

@ajnyga
Copy link
Collaborator

ajnyga commented Oct 18, 2023

Hey @librariam @nils-stefan-weiher @pmangahis. In your experience, when is this feature usually required:

  1. Before the Submission is published, ie. during the editorial process
  2. Right after the Submission has been published, ie. when there is just one version
  3. When there are multiple versions.

Also, we are considering how likely it would be that when an editor wants to change the language, they start by creating a new version?

The reason why we are asking is that the locale setting at the moment is stored in the Submission object. This means that if we want to keep it there, only options 1 and 2 above are possible. With option 3 we would need to move the locale setting from Submission to Publication and this will likely have a lot of implications.

@pmangahis
Copy link

The issue of being unable to see the submission languages has come up for clients when a journal accepts submissions in multiple languages and then decides to change this. They then run into the issue of being unable to edit the existing metadata information because the language of submission has been turned off. There is no way for the Editors to see this on the front end, and the Systems would be required to look in the database to see what the original language was and manually update it to allow them to update

It would also be helpful to see this during the submission process. Particularly when trying to decide who to send the review to. We've received feedback from multilingual journals that requests have been sent to reviewers who don't speak the language of submission. It is a pretty easy mistake to make when they cannot see that the author has pre-filled the submission language and metadata in multiple languages.

@jnugent
Copy link
Member

jnugent commented Oct 18, 2023

@ajnyga there was a bug I found earlier that is closed now where a locale column ended up on the publications table and did indeed cause problems. #7958

@ajnyga
Copy link
Collaborator

ajnyga commented Oct 19, 2023

Thanks @pmangahis. So it seems that the issue in your case has been mostly the inability to see the submission language during the process. This is also being considered here in addition to allowing editors to change the primary locale of a submission.

For the related issue, not able to see metadata for locale that has been turned off, we are working on an improvement where the forms are always accessible for the languages that have been used in the submission regardless of the settings. See #9425

@MiKoko856
Copy link

Please let me know if this issue has been resolved in OJS 3.3.010.

@ajnyga
Copy link
Collaborator

ajnyga commented Oct 28, 2023

hi @MiKoko856, no this is an open issue we are working on now.

@MiKoko856
Copy link

Hi @ajnyga, it is a great pity. Is it already possible to determine in which version of OJS this serious problem will be solved?
Is there any solution to this problem other than deleting the faulty submissions and re-entering all the metadata with only minor corrections to the title and language of the submissions?

@marcbria
Copy link
Collaborator

If you are in a hurry, you can edit this directly in your DB.
I can help you with this if you like. Just open a post in the support forum and mention me.

But please don't rush the developers.
There are a thousand fronts and everyone considers that their problem is more urgent than that of others.
Stressing them with our urgencies does not make their work easier.

Cheers,
m.

@asmecher
Copy link
Member

@MiKoko856, we expect it'll be possible to change the submission language in OMP/OPS/OJS 3.5, which is the next major release. But can you describe your use case for changing the metadata? For example, is it due to a change in journal policy ("we no longer support language XYZ but want to continue existing submissions"), author error (selecting the wrong language), or something else?

@MiKoko856
Copy link

@marcbria and @asmecher, my case of changing metadata: it results from the need to correct the author's error (choosing the wrong language of the submitted text).

jyhein added a commit to jyhein/ojs that referenced this issue Nov 15, 2023
jyhein added a commit to jyhein/ojs that referenced this issue Nov 15, 2023
@bozana
Copy link
Collaborator

bozana commented Sep 25, 2024

All PRs from here #5502 (comment) are merged.
I will however keep the issue open, because some further UI changes are needed -- it needs to be migrated to the new workflow page, which @jardakotesovec would do, so he can ask me or @jyhein here to verify it it works as intended also on the new workflow page...

jardakotesovec added a commit to jardakotesovec/ojs that referenced this issue Oct 7, 2024
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Oct 7, 2024
@jardakotesovec
Copy link
Contributor

migration to new workflow page:
ui-library: pkp/ui-library#422
ojs (e2e test): pkp/ojs#4463

jardakotesovec added a commit to pkp/ui-library that referenced this issue Oct 7, 2024
jardakotesovec added a commit to pkp/ojs that referenced this issue Oct 7, 2024
#4463)

* pkp/pkp-lib#5502 Migrate change language functionality to new workflow page, migrate e2e test

* Clean up comment
@jardakotesovec
Copy link
Contributor

@jyhein @bozana Its merged now. If you could just help me to verify that it works as intended and I did not introduce any bug that would very helpful. Than this could be closed.

Thank you.

@bozana
Copy link
Collaborator

bozana commented Oct 8, 2024

Tested and everything seems to be OK, thus closing...

@bozana bozana closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Projects
None yet
Development

No branches or pull requests