Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to access unpublished articles when not logged in #5563

Closed
NateWr opened this issue Feb 27, 2020 · 9 comments
Closed

Possible to access unpublished articles when not logged in #5563

NateWr opened this issue Feb 27, 2020 · 9 comments
Assignees
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Milestone

Comments

@NateWr
Copy link
Contributor

NateWr commented Feb 27, 2020

Describe the bug
It is possible to access unpublished articles when not logged in or to access unpublished articles which you are not assigned to.

@NateWr NateWr added the Bug:3:Critical A bug that prevents a substantial minority of users from using the software. label Feb 27, 2020
@NateWr NateWr added this to the OJS/OMP 3.2 milestone Feb 27, 2020
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 27, 2020
NateWr added a commit to NateWr/ojs that referenced this issue Feb 27, 2020
@NateWr
Copy link
Contributor Author

NateWr commented Feb 27, 2020

It looks like this went wrong with an attempt to implement a preview feature. Rather than sort out the access control issues at this late stage, I've removed the preview button and blocked all access to unpublished articles on the frontend.

I checked OMP. There was no preview feature and no access to unpublished articles.

PRs:
#5564
pkp/ojs#2651

@NateWr NateWr self-assigned this Feb 27, 2020
asmecher added a commit that referenced this issue Feb 28, 2020
asmecher pushed a commit to pkp/ojs that referenced this issue Feb 28, 2020
asmecher pushed a commit to ajnyga/ojs that referenced this issue Feb 28, 2020
@asmecher
Copy link
Member

Thanks, @NateWr -- merged and cherry-picked to OPS.

MedAhamada pushed a commit to Maanrifa/ojs that referenced this issue Apr 19, 2020
@Vitaliy-1
Copy link
Collaborator

@NateWr If the article is in the unpublished state after being published, it still can be viewed without authorization in 3.2.0-3.

@NateWr
Copy link
Contributor Author

NateWr commented May 14, 2020

Can you describe what you mean by "if the article is in the unpublished state after being published"? If it is published it should have STATUS_PUBLISHED.

@Vitaliy-1
Copy link
Collaborator

Article that was once published but then unpublished by pressing unpublish button.

@Vitaliy-1
Copy link
Collaborator

Submission:

208	uk_UA	1	4	2019-12-17 22:06:47	2020-01-20 11:39:34	3	0	5	173	2020-05-14 16:21:03

Publication:

174	0	2020-03-23	2020-05-14 16:21:03	uk_UA	336	4	4	208	1		4	

Or it should to be this way?

@Vitaliy-1
Copy link
Collaborator

Ahh, by ID I see that the 4th version is unpublished which means that 3rd should be shown instead (publication with id 173), right?

@Vitaliy-1
Copy link
Collaborator

(a bit confusing to me but looks like it works as it should, false alarm)

@NateWr
Copy link
Contributor Author

NateWr commented May 14, 2020

👍 Yeah you can unpublish a previously published version. But if another published version exists, the submission should remain available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Projects
None yet
Development

No branches or pull requests

3 participants