Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms shouldn't submit data from FieldHTML form fields #6969

Closed
NateWr opened this issue Apr 21, 2021 · 1 comment
Closed

Forms shouldn't submit data from FieldHTML form fields #6969

NateWr opened this issue Apr 21, 2021 · 1 comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.4.0-0

Comments

@NateWr
Copy link
Contributor

NateWr commented Apr 21, 2021

Describe the bug
A FieldHTML field is used to display information in a form without any input. However, the Form.vue component will still compile these fields into the data that is sent when the form is submitted.

The Form.vue component should check the field type to determine if it should be included in the submit values. Perhaps FieldHTML.inc.php should have a property to define this.

To Reproduce
Steps to reproduce the behavior:

  1. Open the form to edit a default email template at Settings > Workflow > Emails.
  2. Inspect the submit values with dev tools and see that the description is included.

What application are you using?
3.4 pre-release
@NateWr NateWr added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Apr 21, 2021
@NateWr NateWr mentioned this issue Apr 21, 2021
Closed
NateWr added a commit to pkp/ui-library that referenced this issue Apr 21, 2021
@NateWr
pkp/pkp-lib#6969 Fix email template description field shoudln't have …
36d914c 
…value
@NateWr NateWr added this to the OJS/OMP/OPS 3.4 milestone Apr 21, 2021
@NateWr
Copy link
Contributor Author

NateWr commented Apr 21, 2021

This turned out to be specific to the EmailTemplatesListPanel. There a FieldDescription is created programatically and the value is assigned when it shouldn't be. Fixed in the commit above.

@NateWr NateWr closed this as completed Apr 21, 2021
@NateWr NateWr mentioned this issue Nov 1, 2021
Closed
henriqueramos pushed a commit to henriqueramos/ui-library that referenced this issue Jan 20, 2022
@NateWr
pkp/pkp-lib#6969 Fix email template description field shoudln't have …
4c5e9a7 
…value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.4.0-0
Development

No branches or pull requests
1 participant
@NateWr