pkp/pkp-lib#9552 add masthead option to user roles #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
approved these changes
Jan 9, 2024
bozana
force-pushed
the
9552
branch
4 times, most recently
from
d418be0
to
60b5f0a
Compare
|
@asmecher, may I ask you to take a look at this second commit here: 60b5f0a ? -- For some reason now the PostgreSQL does not return the user groups ordered by ID and for some reason we assume that on several places in the code -- for example: here and here -- so that now the PostgreSQL tests could not pass without it. |
|
Thanks, and good to know that this can be an issue! Please go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s. #9552