This repository has been archived by the owner on Oct 28, 2023. It is now read-only.
preamble and blame tweaks #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkra
reviewed
Jan 12, 2018
| @@ -123,6 +123,13 @@ for (let name of names) { | |||
| renamedNode.classList.add('name'); | |||
| } | |||
|
|
|||
| // convert blames to spans | |||
There was a problem hiding this comment.
Just to check this is intentional: this will move the blame-span out of the heading, causing a break between heading and blame. I'm guessing you want to change the the theorem headings later?
There was a problem hiding this comment.
Ah, all I know is it looked good.
| @@ -67,6 +67,12 @@ licensing.classList.add('license'); | |||
| licensing.innerHTML = 'Derived from <a href="' + articleMeta.source + '">' + articleMeta.source + '</a>, ' + articleMeta.license + ' and licensed as such.' | |||
| articleInfo.appendChild(licensing); | |||
|
|
|||
| // preamble | |||
|
|
|||
| const preamble = document.querySelector('preamble'); | |||
|
Very Cool! A question is in my review. |
|
Likely unnecessary after current rewrite. |
|
I just totally broke this PR.. I'll integrate the changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a preamble tag, move blame code so both name and blame can be used