Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie authentication; always show version information #175

Closed
wants to merge 1 commit into from
Closed

Fix cookie authentication; always show version information #175

wants to merge 1 commit into from

Conversation

johnsonjh
Copy link

@johnsonjh johnsonjh commented Nov 4, 2020

  • Use .pktcookie for the cookie file name
  • Better log output, mention authorization, etc
  • Make rpcclient actually use the cookie data
  • Try user specified user/pass before the cookie
  • Implement cookie data authentication cache
  • Unconditionally output pktd version information

@johnsonjh
Copy link
Author

johnsonjh commented Nov 5, 2020

This is a Travis false positive that is already fixed in #144

@johnsonjh
Copy link
Author

Likely depends on PR #132 for proper behavior.

@cjdelisle
Copy link
Member

conflicts

@johnsonjh
Copy link
Author

Will fixup

 * Use .pktcookie for the cookie file name
 * Better log output, mention authorization, etc
 * Make rpcclient actually use the cookie data
 * Try user specified user/pass before the cookie
 * Implement cookie data authentication cache
 * Unconditionlly output pktd version information
@johnsonjh
Copy link
Author

@cjdelisle autorebased

@johnsonjh
Copy link
Author

Auto-merging pktd.go
Auto-merging config.go
Merge made by the 'recursive' strategy.
 config.go                   | 10 +++-----
 pktconfig/util.go           |  4 +--
 pktd.go                     | 14 ++++++++---
 rpcclient/cookiefile.go     | 41 ++++++++++++++++++++++++++++++
 rpcclient/infrastructure.go | 61 +++++++++++++++++++++++++++++++++++++++++++--
 5 files changed, 116 insertions(+), 14 deletions(-)
 create mode 100644 rpcclient/cookiefile.go

@johnsonjh
Copy link
Author

  • NOTE: Applied to WIP rebase branch successfully after manual rebase.

@johnsonjh johnsonjh closed this Dec 28, 2020
@johnsonjh johnsonjh deleted the securecookie branch December 28, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants