forked from btcsuite/btcd
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cookie authentication; always show version information #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonjh
commented
Nov 4, 2020
•
edited
Loading
edited
- Use .pktcookie for the cookie file name
- Better log output, mention authorization, etc
- Make rpcclient actually use the cookie data
- Try user specified user/pass before the cookie
- Implement cookie data authentication cache
- Unconditionally output pktd version information
This is a Travis false positive that is already fixed in #144 |
Likely depends on PR #132 for proper behavior. |
conflicts |
Will fixup |
* Use .pktcookie for the cookie file name * Better log output, mention authorization, etc * Make rpcclient actually use the cookie data * Try user specified user/pass before the cookie * Implement cookie data authentication cache * Unconditionlly output pktd version information
@cjdelisle autorebased |
|
This was referenced Nov 26, 2020
Closed
Closed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.