Force pld and pldctl to not use macaroons #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following things were added/changed/fixed:
. ignoring the CLI flags and forcing the option --no-macaroons on both pld and pltctl main fuctions;
. removed all macaroon config options from both pld config file and pld CLI options;
. added a delay in the testSignOutputUsingTweaks() test case, as it was failing due to the payment transaction was starting before the funding transactions were confirmed;
. added two script to automate integration tests for pld and pldctl programs;
. I kept some debug traces used during the debugging of the test code;