Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #1

Closed
elfring opened this issue Feb 1, 2018 · 3 comments
Closed

reserved identifier violation #1

elfring opened this issue Feb 1, 2018 · 3 comments

Comments

@elfring
Copy link

elfring commented Feb 1, 2018

I would like to point out that identifiers like “__XAVS2ENC_H__” and “_U_do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@luofalei
Copy link
Member

luofalei commented Feb 2, 2018

Does it mean that we should revise the identifiers like __XAVS2ENC_H__ to XAVS2ENC_H by removing leading and trailing underscores? Thank you.

@luofalei
Copy link
Member

luofalei commented Feb 4, 2018

@elfring Thanks for your suggestion, the identifiers has been fixed.

@luofalei luofalei closed this as completed Feb 4, 2018
@elfring
Copy link
Author

elfring commented Feb 5, 2018

Thanks for your source code improvement.

Another update candidate was left over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants