Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPi Release CI #83

Merged
merged 9 commits into from
Feb 16, 2023
Merged

Fix PyPi Release CI #83

merged 9 commits into from
Feb 16, 2023

Conversation

franklinselva
Copy link
Member

No description provided.

@franklinselva
Copy link
Member Author

@arbimo The Pypi release currently fails since the version is already available in the project. It seems we should be bumping the version to pass the test.

Copy link
Member

@arbimo arbimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks reasonable but I have no experience with this.

Could you minimize the changes (one commit with necessary additions and no autoformatin) and remake it target the master branch ?

@arbimo
Copy link
Member

arbimo commented Feb 16, 2023

Also, you may have to change the filename (i.e. include version in it) for it to work. (Again no experience, just looking at the error message in the CI)

@franklinselva franklinselva marked this pull request as ready for review February 16, 2023 10:24
@franklinselva franklinselva self-assigned this Feb 16, 2023
@franklinselva
Copy link
Member Author

franklinselva commented Feb 16, 2023

I have updated the changes. Regarding the PyPI release job, I think the version number should be updated by bumping the tag solving the current issue. But it may still fail for version 0.0.4 since it is already available.

@arbimo arbimo merged commit ae2fcf3 into master Feb 16, 2023
@arbimo arbimo deleted the up-aries-pypi branch February 16, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants