use ref to avoid calling overloaded methods. Fix #697

plack · Sep 14, 2023 · 5a52015 · 5a52015
1 parent db2a055
commit 5a52015
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/Plack/Middleware/StackTrace.pm b/lib/Plack/Middleware/StackTrace.pm
@@ -55,7 +55,8 @@ sub call {
         $trace = $caught_trace if $caught_trace;
     }
 
-    if ($trace && ($caught || ($self->force && ref $res eq 'ARRAY' && $res->[0] == 500)) ) {
+    # Use ref $trace to avoid calling as_string twice when it's not necessary
+    if (ref $trace && ($caught || ($self->force && ref $res eq 'ARRAY' && $res->[0] == 500)) ) {
         my $text = $trace->as_string;
         my $html = $trace->as_html;
         $env->{'plack.stacktrace.text'} = $text;