Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Moved from vanilla JS to React #85

Merged
merged 1 commit into from
Jun 23, 2015

Conversation

twolfson
Copy link
Member

This PR transitions from vanilla JS to React. The application has full parity with its master counterpart (e.g. tray notifications, sidebar) as well as some new features. In this PR:

  • Transitioned from vanilla JS to React
  • Added documentation
  • Added test for TeamStore
    • It might be difficult to test the application in full since we would have to mock over Slack
  • Automatically updates sidebar upon login
  • Started transition from iframe watcher for last active domain to using team_url from Slack
  • Fixes Framework discussion #38

Notes:

This transition goes from 300 lines to 1000 lines but:

  • It yields a known architecture
  • 200 of those lines are new tests
  • Handles DOM interactions automatically (e.g. no element tracking for addition/removal)

As mentioned in #38, there was a bit of friction with React's initial setup. Out of the box, there is no support for nw.js's HTML attributes like nwfaketop. As a result, we wrote an interim script to compile to get it to work. Before this PR lands, I will probably break that into its own repository.

/cc @wlaurance

@mathieumg
Copy link
Collaborator

🎉

@twolfson twolfson force-pushed the dev/react.attempt.1.sqwished branch from 485016e to e75f2e6 Compare June 21, 2015 00:09
@twolfson twolfson force-pushed the dev/react.attempt.1.sqwished branch from e75f2e6 to 06e2d02 Compare June 21, 2015 00:11
@wlaurance
Copy link
Contributor

👍 Looks great to me!

Should we wait for the interim script to be in its own repository?

@twolfson
Copy link
Member Author

Nah, let's land it as is. That breakout can be done in a follow-up PR.

wlaurance added a commit that referenced this pull request Jun 23, 2015
@wlaurance wlaurance merged commit aadb795 into plaidchat:master Jun 23, 2015
@twolfson twolfson deleted the dev/react.attempt.1.sqwished branch June 24, 2015 02:13
@twolfson
Copy link
Member Author

@wlaurance It looks like you forgot to publish a release as this was landed =/ Going to release this as a minor release since everything should be at parity/backwards compatible

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants