fix classifier to archiveClassifier #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wasnot @SojiroNishimura |
|
自分は大丈夫と思いますが、時間が許すのなら一応 @nkmrh さんにも確認していただいた方がいいかもしれません。 |
|
@nkmrh |
nkmrh
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
対応ありがとうございます！
余談ですが expo の方ではすでに削除されているようですね。 https://github.com/expo/expo/pull/22537/files
|
@nkmrh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle 7.5.1以降、classifierはdeprecatedになる(以降のversionで消えてbuildが通らなくなるため)、archiveClassifierに変更しました。ご確認お願いします。
https://docs.gradle.org/7.5.1/dsl/org.gradle.api.tasks.bundling.Jar.html
追記
archiveClassifierは5.3から追加されたプロパティ: https://docs.gradle.org/5.3/dsl/org.gradle.api.tasks.bundling.Jar.html