docked vs. undocked widget opening

[m-rau]

Some widget, e.g. the JIRA link widget must be opened without iframe.
Therefore we need the following opening actions:

1. open in widget manager (embedded) - default behavior
2. open in standalone with regular navigation bar, menu item, close button etc. (standalone) - triggered with target = "blank"
3. open undocked without iframe, triggered with target = "?"

next step

what are your thoughts?

[marekmru]

I used the flag target=blank for the undocked mode (if target=blank then open without iframe in new tab). I don’t see a difference between 1 and 2. For me both are triggered by only different user actions (open_in_new icon and click on the widget area) Von: Michael Rau <notifications@github.com> Antworten an: plan-net/core4 <reply@reply.github.com> Datum: Montag, 20. Mai 2019 um 09:24 An: plan-net/core4 <core4@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Betreff: [plan-net/core4] docked vs. undocked widget opening (#46) Some widget, e.g. the JIRA link widget must be opened without iframe. Therefore we need the following opening actions: 1. open in widget manager (embedded) - default behavior 2. open in standalone with regular navigation bar, menu item, close button etc. (standalone) - triggered with target = "blank" 3. open undocked without iframe, triggered with target = "?" next step what are your thoughts? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#46?email_source=notifications&email_token=AB7W6TPPMZ3B7USPKMYOYX3PWJG4DA5CNFSM4HN7FFIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUU2IFQ>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB7W6TLII7VUTPH3HVHMH2DPWJG4DANCNFSM4HN7FFIA>.

[m-rau]

tested but not working. Please check with link widget in home4.api.v1.server.py.

[marekmru]

This currently only works when you click the 'open in new' button in the upper left part of the widget.
When clicking on the widget itself it opens default.
Task:
Add functionality also for click on the widget itself.

[marekmru]

Resolved in: #74

[m-rau]

Not resolved. If a widget has a setting target == "blank" then the action "open" must still open the widget in a new tab. The requirement is, that widget with target == "blank" cannot (never ever) be opened inside the app manager.

[marekmru]

The widget sidebar target was not included - is fixed now in Resolved in #82

[m-rau]

So can we close this ticket?

[m-rau]

So I close.