Adjust yoda-webhook to work better with github.com (cloud) vs GHE

[jens-markussen]

It seems there have been some recent advances on github.com concerning rendering of issue links. The rendering now seems to include both the issue title as well as the issues status (tick mark if done).

Those informations are already put by yoda-webhook mechanism directly and so things are sort of doubled.

To see the effect of the rendering, check out

[jens-markussen]

And the full effect of this

[jens-markussen]

Actually it seems that this "extra good rendering" happens only when issues are shown in some kind of list (like in a > contains block). It is not enabled e.g. for > partof #2

[jens-markussen]

Suggested fix could be

--- a/nodejs/yoda-webhook/yoda-utils.js
+++ b/nodejs/yoda-webhook/yoda-utils.js
@@ -319,13 +319,13 @@ function makeChildBlock(ownRef, childIssues) {
                        if (issueRefs[i].issue == null) {
                                refLine = refLine + "- [ ] " + shortRef + " **Unable to get issue details - non-existing issue/access right problem?**";
                        } else {
-                               refLine += "- [";
+                               refLine += "- ";

                                if (issueRefs[i].issue.state == "closed") {
-                                       refLine += "x] ";
+//                                     refLine += "[x] ";
                                        totalClosed++;
                                } else {
-                                       refLine += " ] ";
+//                                     refLine += "[ ] ";
                                        totalOpen++;
                                }
                                refLine += shortRef;
@@ -346,7 +346,7 @@ function makeChildBlock(ownRef, childIssues) {
                                if (estimate != 0)
                                        refLine += " (" +  estimate + " / " + remaining + ")";

-                               refLine += " *" + issueRefs[i].issue.title.trim() + "*";
+                               // refLine += " *" + issueRefs[i].issue.title.trim() + "*";
                        }
                        logger.debug("refline: '" + refLine + "'");
                        issueRefs[i].refLine = refLine;

Then there is the question is worth making backwards compatible.

[jens-markussen]

To make it absolutely clear. See below text in edit and preview mode: