Introduce Merkle Patricia Trie #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #939 +/- ##
==========================================
- Coverage 88.81% 88.55% -0.26%
==========================================
Files 288 315 +27
Lines 26766 27652 +886
==========================================
+ Hits 23771 24486 +715
- Misses 1466 1620 +154
- Partials 1529 1546 +17
|
moreal
force-pushed
the
feature/implement-merkle-tree
branch
2 times, most recently
from
00fb143
to
c296062
Compare
Merged
moreal
force-pushed
the
feature/implement-merkle-tree
branch
5 times, most recently
from
57ce5ab
to
13176f1
Compare
moreal
force-pushed
the
feature/implement-merkle-tree
branch
2 times, most recently
from
8d10129
to
ca3b197
Compare
moreal
requested review from
earlbread,
dahlia,
limebell,
longfin and
riemannulus
moreal
force-pushed
the
feature/implement-merkle-tree
branch
from
ca3b197
to
9aa6ab1
Compare
|
|
longfin
reviewed
Aug 19, 2020
| public void ForkStates<T>(Guid sourceChainId, Guid destinationChainId, Block<T> branchpoint) | ||
| where T : IAction, new() | ||
| { | ||
| // Do nothing. |
There was a problem hiding this comment.
Is it okay that we don't anything here even throwing / logging error?
There was a problem hiding this comment.
Actually, ForkStates(…) is called in BlockChain<T>.Fork(…) so if it throws exceptions it will always fail. And it is intended.
moreal
force-pushed
the
feature/implement-merkle-tree
branch
from
aae7bcd
to
a1095bf
Compare
moreal
force-pushed
the
feature/implement-merkle-tree
branch
2 times, most recently
from
e327345
to
b79cbaa
Compare
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
It is for RocksDB. Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
See https://docs.microsoft.com/en-us/dotnet/csharp/nullable-references Co-Authored-By: Hong Minhee <hong.minhee@planetariumhq.com>
Reorder items Co-Authored-By: Hong Minhee <hong.minhee@planetariumhq.com>
- `BytesEqualityComparer.Equals(…)` Co-Authored-By: Hong Minhee <hong.minhee@planetariumhq.com>
- `HashNode`
- Update XML documents Co-Authored-By: Ko Chanhyuck <lime_bell@naver.com>
- Fix a missing nullable Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
moreal
dismissed stale reviews from limebell, longfin, riemannulus, and earlbread
via
7d98609
moreal
force-pushed
the
feature/implement-merkle-tree
branch
from
04e8700
to
7d98609
Compare
earlbread
approved these changes
Aug 24, 2020
longfin
approved these changes
Aug 24, 2020
dahlia
approved these changes
Aug 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this pull request is based on #950 . It MUST be merged after #950 merged.
Tasks
ITrie.TryGet,ITrie.SetIKeyValueStorefor eachIStoreimplementationThere may be more updates or the end.