Separate IStore into IStateStore #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreal
force-pushed
the
feature/separate-state-store
branch
from
a86265e
to
6b8c473
Compare
Codecov Report
@@ Coverage Diff @@
## main #950 +/- ##
==========================================
+ Coverage 88.13% 88.20% +0.06%
==========================================
Files 276 280 +4
Lines 25270 25458 +188
==========================================
+ Hits 22272 22455 +183
- Misses 1537 1540 +3
- Partials 1461 1463 +2
|
moreal
requested review from
dahlia,
limebell,
earlbread,
longfin and
riemannulus
longfin
reviewed
Aug 10, 2020
moreal
force-pushed
the
feature/separate-state-store
branch
from
c79eeae
to
af1447b
Compare
longfin
previously approved these changes
Aug 11, 2020
riemannulus
reviewed
Aug 11, 2020
limebell
reviewed
Aug 12, 2020
riemannulus
previously approved these changes
Aug 12, 2020
earlbread
reviewed
Aug 12, 2020
longfin
previously approved these changes
Aug 12, 2020
earlbread
previously approved these changes
Aug 12, 2020
limebell
previously approved these changes
Aug 12, 2020
riemannulus
previously approved these changes
Aug 12, 2020
earlbread
previously approved these changes
Aug 14, 2020
longfin
previously approved these changes
Aug 14, 2020
limebell
previously approved these changes
Aug 14, 2020
riemannulus
previously approved these changes
Aug 14, 2020
dahlia
reviewed
Aug 14, 2020
| public interface IStateStore | ||
| { | ||
| /// <summary> | ||
| /// Sets states mapped as relation <see cref="Block{T}.Hash"/> → states. |
There was a problem hiding this comment.
What does “mapped as relation …” mean?
There was a problem hiding this comment.
Sadly, I couldn't find well expression for it 😢. Actually I wanted to say like Stores the key-value pair with blockHash as key, states as value.
moreal
dismissed stale reviews from riemannulus, limebell, longfin, and earlbread
via
4bf7ab2
longfin
requested review from
longfin,
limebell,
earlbread,
riemannulus and
dahlia
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
moreal
force-pushed
the
feature/separate-state-store
branch
from
4bf7ab2
to
0f0aaa4
Compare
dahlia
approved these changes
Aug 14, 2020
limebell
approved these changes
Aug 14, 2020
earlbread
approved these changes
Aug 14, 2020
longfin
approved these changes
Aug 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request separates
IStore's functions to handle state intoIStateStore.Also, it's a step among steps to apply Merkle Patricia Trie (#939).