Fix SQLite write locking #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o check for write locking
mplorentz
commented
Jan 26, 2022
| @@ -2340,157 +2340,155 @@ class ViewDatabase { | |||
|
|
|||
| var reports = [Report]() | |||
| var skipped: UInt = 0 | |||
| try db.transaction { // also batches writes! helps a lot with perf | |||
There was a problem hiding this comment.
This is really the only important change to this file. This line (and it's closing brace) were removed. Everything else was an indentation change, but Github doesn't show it that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#305 This removes the
db.transactionwrapper inViewDatabase.fillMessages(). While wrapping our writes to SQLite in a transaction gives a small (~6%) speed boost to the write operations, it creates an exclusive lock on the database, preventing any other reads or writes from taking place. By inserting rows individually instead of in a transaction, we allow readers to read from the database in between insertions. This is important when we are copying over large amounts of data from go-ssb, as a big write transaction can take more than 10 seconds. And it fits with our general strategy of using SQLite as a cache layer and optimizing it for read performance.