Dynamically generate urls from current config. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobstr
force-pushed
the
live-urls
branch
2 times, most recently
from
1e680e5 to
50aa3a5
Compare
This allows the configured root url to be changed and for subsequent requests to reflect said change in the root url.
|
This looks nice @jacobstr. We're using Please merge. |
|
Feel free to cut a release after merging. Since we're pre 1.0, this should be a minor release (this will keep The |
jacobstr
added a commit
that referenced
this pull request
Aug 23, 2015
Dynamically generate urls from current config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the configured root url to be changed and for subsequent
requests to reflect it.