Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected FA components. Added html tag to disable eslinter mixed v-i… #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Corrected FA components. Added html tag to disable eslinter mixed v-i… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/Navbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<nav class="navbar navbar-light fixed-top">
<div class="navbar-text ml-auto d-flex">
<button class="btn btn-sm btn-outline-success" @click="$parent.$emit('toggle')">
<i class="fas fa-dollar-sign"></i>
<font-awesome-icon icon="dollar-sign"></font-awesome-icon>
</button>
<div class="dropdown ml-2" v-if="cart.length>0">
Expand All @@ -14,7 +13,7 @@
aria-expanded="false"
>
<span class="badge badge-pill badge-light">{{cartQty}}</span>
<i class="fas fa-shopping-cart mx-2"></i>
<font-awesome-icon icon="shopping-cart" class="mx-2"></font-awesome-icon>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Nothing wrong with this, but could be written as <font-awesome-icon icon="shopping-cart" class="mx-2" /> I guess. Personal preference.

<price :value="Number(cartTotal)"></price>
</button>
<div class="dropdown-menu dropdown-menu-right" aria-labelledby="cartDropdown">
Expand Down
1 change: 1 addition & 0 deletions src/components/ProductList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!-- eslint-disable vue/no-use-v-if-with-v-for,vue/no-confusing-v-for-v-if -->
<template>
<transition-group name="fade" tag="div" @beforeEnter="beforeEnter" @enter="enter" @leave="leave">
<div
Expand Down