Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone: Take unknown fields into account #55

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

misberner
Copy link
Contributor

The existing implementation of CloneVT was silently discarding unknown fields, breaking some basic assumptions (such that a clone should always be equal to the original). Thus, extend the test generation to also copy unknown fields.

Unit tests are included.

@vmg vmg merged commit 0ae748f into planetscale:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants