Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to add instructions to use with connect #70

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

joshcarp
Copy link
Contributor

@joshcarp joshcarp commented Dec 9, 2022

Hello,
So this adds instructions to add vtprotobuf to connect.

connect-go uses the same interface as the grpc for codec and so it does work grpc.Codec{} but another alternative would be to copy the grpc directory to make a connect directory to decouple them.

Let me know what you think!

@mattrobenolt
Copy link
Member

👋 hey @joshcarp lemme compare this with the codec I wrote. It might just be the same here and I can unify.

@mattrobenolt
Copy link
Member

Ok, so in my experience, we've opted to use something more like this: https://github.com/planetscale/psdb/blob/main/core/codec/codec.go

The main difference being, it also supports the fallback to non vtprotobuf encoded objects. It's not always practical to assume vtprotobuf is used for every message.

@vmg what are your thoughts here?

@joshcarp
Copy link
Contributor Author

@mattrobenolt do you want me to add that package here as a new connect package?

@vmg
Copy link
Member

vmg commented Jan 27, 2023

@joshcarp: No, I think it's perfectly OK if you host the package yourself and we point at it from the documentation. I'll merge this!

@vmg vmg merged commit de2239c into planetscale:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants