#213 Improve and fix URI parsing #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebbo94BY
force-pushed
the
#213-factory-fails-without-username-and-password
branch
from
4c7efad
to
f4e3030
Compare
- Fix `Call to a member function toString()` on null when using `factory()` without credentials - Allow `factory()` without username and password - Use PHP native `parse_url()` function to simplify code - Improve and refactor some validations in general - Adjust and extend PHPUnit tests
Sebbo94BY
force-pushed
the
#213-factory-fails-without-username-and-password
branch
from
f4e3030
to
2ab9e5f
Compare
Sebbo94BY
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call to a member function toString() on nullwhen usingfactory()without credentialsfactory()without username and passwordparse_url()function to simplify codecloses #213