Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deployment docs2 #168

Closed
wants to merge 14 commits into from
Closed

Feature/deployment docs2 #168

wants to merge 14 commits into from

Conversation

PhilippMDoerner
Copy link
Contributor

@PhilippMDoerner PhilippMDoerner commented Jul 5, 2022

This overhaul of the text adds an example that allows compiling to alpine.

It mildly overhauls the structure to be able to do so and fixes some format issues and improves how links are handled.
I have tested what I wrote there myself on my own project of nimstoryfont. Produces a beautiful 25.5 MB Alpine image.

QUESTION:
I do plan on adding examples mini-projects that follow the examples coded here to "prove" that this works in live code.

The question is whether that shall be a separate PR and merge this now to have smaller PRs and quicker access to what I wrote, or whether we wait for me to write up the mini-examples and make them also part of this PR.

Edit:
It is quite frustrating that git keeps throwing in the previously merged commits. No idea how to stop that.

@ringabout
Copy link
Member

It is quite frustrating that git keeps throwing in the previously merged commits. No idea how to stop that.

The easy way is to use GitHub desktop and directly edit deployment file on this repo. Another easy way is to delete your fork, create a new fork and git clone the new one.

I always set a base branch without any my new commits to generate other branches. git reset is my favourite command to discard unnecessary old commits.

@ringabout
Copy link
Member

The question is whether that shall be a separate PR and merge this now to have smaller PRs and quicker access to what I wrote, or whether we wait for me to write up the mini-examples and make them also part of this PR.

Either way is fine. I prefer small changes. Ideally one PR should only fulfill one purpose.

@PhilippMDoerner
Copy link
Contributor Author

Alright, I'll close this PR because it has so much unnecessary stuff attached to it.
I made a new PR just via editing the file on github, it retains the same core changes as this PR, namely that it's an addition of how to compile on alpine with a bit of structural and formatting improvements.

The new PR is #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants