feat(TableViewDriver): allow lightweightDiffing #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickell-andrew
commented
Nov 15, 2023
| self._tableViewModel = newModel | ||
| self._tableViewModel = newModel | ||
| if old == new { | ||
| self.refreshViews(refreshContext: .contentOnly) | ||
| } else { |
There was a problem hiding this comment.
New behavior is opt in for folks that set automaticDiffing to true and also set the new parameter lightweightDiffing to true.
nickell-andrew
requested review from
njw438,
DerCSpringer and
jeffrey-compton
DerCSpringer
approved these changes
Nov 15, 2023
njw438
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
lightweightDiffingoption for use with very large but largely static listsIssue fixed: #
For forms we found that performance is massively better with automatic diffing disabled for large forms. Unfortunately, doing a full reload of tableview data causes text fields to resign focus which is a bad experience for end users.
Lightweight diffing is an option I'd like to explore for forms since we don't frequently add/remove/move sections/cells.
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.