Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Generate Admin Login Credentials instead of static default values #36

Closed
stranger-danger-zamu opened this issue Sep 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@stranger-danger-zamu
Copy link

Hey,

One thing I did notice was that you are using demo credentials for login.

More mature OSS usually uses a patterns where the username and password is generated and printed out into the logs on first run and to a text file on disk. If the user misses the admin password in the logs, they can just run a docker exec <planka container name> cat <some persistent location> and get the password.

This is both safer, as there is no default user that just exists and might be forgotten about, and a better user experience, it definitely took me a lot longer than I would like to admit to figure out how I was supposed to get past the login page.

This looks super promising and open source, thanks for all the work so far and keep up the good work!

@meltyshev
Copy link
Member

Hi! Sorry for the long answer. Yes, already thought about that, I don't like that demo user too.

@meltyshev meltyshev added the enhancement New feature or request label Oct 5, 2020
@NeodymiumPhish
Copy link

A better solution might be to have a default "demo" / start account declared in the environmental variables when you make the container. Like -e DEMO_USER=<insert username> and -e DEMO_USER_PASS=<insert password>.

On the backend (no idea how to implement this part, but it's just a thought), at launch Planka could check for other administrator accounts in the database and disable the Demo account if other admin accounts exist.

Alternatively, the onboarding could have the option/suggestion of deleting the demo account once a new admin is created, and the database could flag the account so that it's inaccessible after the admin checks the box to delete/disable the demo account.

@meltyshev
Copy link
Member

91bc889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants