Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of convering question names to CLI args #82

Merged
merged 4 commits into from
Feb 8, 2021

Conversation

jamescurtin
Copy link
Contributor

Closes #36

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #82 (bc02137) into main (00b7b14) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   96.09%   96.14%   +0.05%     
==========================================
  Files           5        5              
  Lines         307      311       +4     
  Branches       35       35              
==========================================
+ Hits          295      299       +4     
  Misses         10       10              
  Partials        2        2              
Impacted Files Coverage Δ
columbo/_cli.py 97.70% <ø> (-0.06%) ⬇️
columbo/_interaction.py 99.27% <100.00%> (+0.03%) ⬆️

Copy link

@jhpierce jhpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

columbo/_interaction.py Outdated Show resolved Hide resolved
tests/sample_data.py Show resolved Hide resolved
columbo/_interaction.py Outdated Show resolved Hide resolved
tests/sample_data.py Show resolved Hide resolved
@jamescurtin jamescurtin merged commit 4a7546e into main Feb 8, 2021
@jamescurtin jamescurtin deleted the cli-edge-case branch February 8, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line edge cases
3 participants