Add/gcp #91
Merged
Add/gcp #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2024 11:37
|
Great! |
The-Lum
reviewed
Feb 8, 2024
Comment on lines
+3
to
+7
| !include Common.puml | ||
|
|
||
| !include Networking/all.puml | ||
| !include GCPSimplified.puml | ||
|
|
There was a problem hiding this comment.
Same remarks or similar as k8s:
- Could you change "local URL" to "local stdlib" inclusion (with
<>)?
To:
!include <gcp/Common.puml>
!include <gcp/Networking/all.puml>
!include <gcp/GCPSimplified.puml>
Regards,
Th.
There was a problem hiding this comment.
I'm sorry. I read it late.
There was a problem hiding this comment.
There was a problem hiding this comment.
@theavege: [Apologie, but PlantUML team would like to deliver a version this week...]
- Do you need help making corrections?
- Should I do it? as you want: ask me...
Regards,
Th.
The-Lum
added a commit
to The-Lum/plantuml-stdlib
that referenced
this pull request
Feb 14, 2024
Fix `Networking.puml`, to follow the remark of: - plantuml#91 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include to stdlib GCP