Try parsing time in Rememberable before giving up #3917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather try to figure out why it is becoming a string in the first place and avoid it. For example, we could try to always make it a string or always an integer to avoid handling all possible scenarios. |
|
Are you using any special mechanism for cookie serialization? |
|
@josevalim afaik the JSON cookie serialization doesn't deserialize timestamps as |
|
I guess we have no option then. Let's handle this in the function you have just extracted. We will need to backport it though. :S |
|
@boblail can you move your patch to the |
lucasmazza
added a commit
that referenced
this pull request
Jan 29, 2016
Time objects aren't properly coerced back when using the JSON cookie serialization, so we need to do it ourselves. To avoid any new JSON serialization issues, we now store the `generated_at` as an String with the timestamp seconds + miliseconds in the cookie but still the previous JSON encoded format. Thanks to @boblail at #3917 for the initial patch.
lucasmazza
added a commit
that referenced
this pull request
Jan 29, 2016
Time objects aren't properly coerced back when using the JSON cookie serialization, so we need to do it ourselves. To avoid any new JSON serialization issues, we now store the `generated_at` as an String with the timestamp seconds + miliseconds in the cookie but still the previous JSON encoded format. Thanks to @boblail at #3917 for the initial patch.
|
Closed by #3927. |
lucasmazza
added a commit
that referenced
this pull request
Jan 31, 2016
Time objects aren't properly coerced back when using the JSON cookie serialization, so we need to do it ourselves. To avoid any new JSON serialization issues, we now store the `generated_at` as an String with the timestamp seconds + miliseconds in the cookie but still the previous JSON encoded format. Thanks to @boblail at #3917 for the initial patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the exception that 048d05a fixes; but the value of
generated_at(now being discarded) was a serialized time:"2016-01-26 17:13:52 UTC".After following these steps:
1. Sign in with Remember me checked
2. Delete the session key (but not
remember_user_token) from the cookies3. Refresh
Using devise
v3.5.5, my application would crash.Using 048d05a, you'd be signed out.
Using this pull request, you'd be signed in.