Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrine images #396

Merged
merged 10 commits into from
Apr 8, 2022
Merged

Shrine images #396

merged 10 commits into from
Apr 8, 2022

Conversation

GabrielLyonB
Copy link
Contributor

@GabrielLyonB GabrielLyonB commented Apr 1, 2022 •
edited
Loading

Objective

  • Update ImageBuilder to allow the use of shrine images.

Description

  • I included shrine and image_processing as a developer dependency.
  • I created a shrine initializer in the dummy app.
  • I included the picture_data column in the Invoice modelo to try the shrine image uploader.
  • I included in the ImageBuilder a case for shrine objects. This includes the use of derivatives.
  • I tested the ImageBuilder based on the tests for paperclip.

@GabrielLyonB GabrielLyonB requested a review from gmq April 1, 2022 21:16
@GabrielLyonB GabrielLyonB requested a review from gmq April 8, 2022 21:28
gmq
gmq reviewed Apr 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
docs/images.md Outdated Show resolved Hide resolved
docs/images.md Outdated Show resolved Hide resolved
@GabrielLyonB GabrielLyonB requested a review from gmq April 8, 2022 21:37
@GabrielLyonB GabrielLyonB merged commit db992b3 into master Apr 8, 2022
@GabrielLyonB GabrielLyonB deleted the shrine-images branch April 8, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmq gmq gmq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielLyonB @gmq