Remove sprockets support #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeyci
reviewed
Mar 14, 2023
gmq
force-pushed
the
remove-sprockets-support
branch
from
ff8faf7
to
54e9b97
Compare
ldlsegovia
reviewed
Mar 16, 2023
| @@ -33,7 +33,6 @@ | |||
| list_row :skills, list_type: :ol | |||
| list_row :contact, localize: true | |||
| list_row :details, localize: true | |||
| attachment_row("My doc", :attachment, label: 'Download file', truncate: false, &:attachment) | |||
difernandez
suggested changes
Mar 16, 2023
| #### Material Theme | ||
| ##### Not compatible when Active Admin has been installed in webpack mode | ||
|
|
||
| Show material design theme using [active_material](https://github.com/vigetlabs/active_material). If you want to use it, you should run the generator using the flag `theme` as follow: |
There was a problem hiding this comment.
We should also remove active_material from gemspec and engine.rb
| @@ -33,17 +33,6 @@ And in another tab: | |||
| bin/webpack-dev-server | |||
| ``` | |||
|
|
|||
| **With Sprockets:** | |||
There was a problem hiding this comment.
a little further down, we should also remove the bundle exec rake sprockets_tests and those commands that no longer exist
gmq
force-pushed
the
remove-sprockets-support
branch
from
54e9b97
to
b7db600
Compare
ldlsegovia
approved these changes
Mar 17, 2023
bessey
pushed a commit
to bessey/activeadmin_addons
that referenced
this pull request
Jun 19, 2023
difernandez
added a commit
that referenced
this pull request
Jun 19, 2023
Fix link to PR #451 in CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the years, Rails has been transitioning away from sprockets for frontend purposes. Maintaining support for both methods of installation has added complexity to every update we make.
This PR removes sprockets support, leaving only support for the Webpacker installation of ActiveAdmin. Although Webpacker is deprecated, it's easy to move files to make Addons work with other frontend bundlers.
It also removes some custom fixes for the Active Material theme.