Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define required ruby version to >=2.7.0 #460

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Define required ruby version to >=2.7.0 #460

merged 1 commit into from
Apr 13, 2023

Conversation

difernandez
Copy link
Contributor

Motivation / Background

This Pull Request has been created because we are supporting ruby 2.6, which has been in EOL for a year. Having 2.6 in our test suite throws error when upgrading nokogiri dependency:
image

Detail

This Pull Request changes removes 2.6 from CI, and sets required_ruby_version in gemspec

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a concise description of what changed and why.
  • Tests are added or updated if you fix a bug or add a feature.
  • Documentation has been added or updated if you add a feature or modify an existing one.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature (under the "Unreleased" heading if this is not a version change).
  • My changes don't introduce any linter rule violations.

@difernandez difernandez changed the title chore(): define required ruby version to >=2.7.0 Define required ruby version to >=2.7.0 Apr 12, 2023
@difernandez difernandez merged commit ea2d2ae into master Apr 13, 2023
@difernandez difernandez deleted the drop-ruby2.6 branch April 13, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants