Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 backport ActiveAdmin v3 support and release new version #479

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

difernandez
Copy link
Contributor

@difernandez difernandez commented Aug 23, 2023

Motivation / Background

This Pull Request has been created because in #477 we made some changes in order for this gem to be compatible with the recently released AA v3, but those changes are, as of now, only available in v2 (now in beta) of this gem. Even though we won't be supporting or backporting features to v1, we think it would be good to backport this particular changes to increase overall compatibility.

Detail

This Pull Request backports said changes in #477 to support v3 of ActiveAdmin in v1 of this gem. Also, in order, for tests to pass, needed to update to most recent ruby and also backport #476 to fix the webdriver issues, and remove EOL rubies from the CI.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a concise description of what changed and why.
  • Tests are added or updated if you fix a bug or add a feature.
  • Documentation has been added or updated if you add a feature or modify an existing one.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature (under the "Unreleased" heading if this is not a version change).
  • My changes don't introduce any linter rule violations.

Mainly, the 'contains' predicate, that was used as default in some components. These predicates were removed from activeadmin v3, since they were backports. More info here activeadmin/activeadmin#8010
We wont't require ruby 3 just yet, but for testing purposes we need to remove it
Backports AA v3 support
@difernandez difernandez force-pushed the v1-backport-AA-v3-support-and-release-new-version branch from aadc069 to 9bed815 Compare August 23, 2023 15:47
This was referenced Aug 23, 2023
@difernandez difernandez merged commit bea9423 into v1 Aug 24, 2023
1 check passed
@difernandez difernandez deleted the v1-backport-AA-v3-support-and-release-new-version branch August 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants