recover etcd: Remove kube-apiserver container to trigger immediate restart #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that kube-apiserver is immediately restarted by kubelet, and that it is healthy. |
cmd/etcd.go
Outdated
| log.Printf("Warning: Unable to restart kubelet on machine %q: %v", mwc.Machine.Name, err) | ||
| log.Printf("[recover etcd] Removing kube-apiserver container on master %q to trigger immediate restart", mwc.Machine.Name) | ||
| if err := removeKubeAPIServerContainer(mwc.Client); err != nil { | ||
| log.Fatalf("Unable to remove kube-apiserver container on master %q: %v", mwc.Machine.Name, err) |
There was a problem hiding this comment.
Hi Daniel, do we want to log fatal here or return the errr
There was a problem hiding this comment.
Good catch, fixing.
cmd/etcd.go
Outdated
| if err != nil { | ||
| return "", fmt.Errorf("error running %q: %v (stdout: %q, stderr: %q)", cmd, err, string(stdOut), string(stdErr)) | ||
| } | ||
| return string(stdOut), nil |
There was a problem hiding this comment.
is trimming of the string, required as well here?
There was a problem hiding this comment.
Yes--without it there is a trailing newline. Fixing.
puneetguptanitj
suggested changes
Aug 14, 2018
puneetguptanitj
approved these changes
Aug 14, 2018
dlipovetsky
force-pushed
the
private/daniel/restart-kube-apiserver
branch
from
8fbda83
to
1d979d9
Compare
|
Squashed. |
ojmhetar
approved these changes
Aug 14, 2018
sarun87
approved these changes
Aug 14, 2018
|
|
||
| func identifyDockerContainer(filters []string, client sshmachine.Client) (string, error) { | ||
| filterFlags := buildDockerFilterFlags(filters) | ||
| cmd := fmt.Sprintf("docker ps --quiet %s", filterFlags) |
There was a problem hiding this comment.
would it be better to use docker inspect --format="{{.Id}}" contianer_name? Although I suppose it would be difficult to get the exact container name.
There was a problem hiding this comment.
Yes, the name includes UIDs that we can't derive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98