Remove deprecated package #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojmhetar
requested review from
dlipovetsky,
puneetguptanitj,
vannrt and
sarun87
dlipovetsky
approved these changes
Nov 5, 2018
cmd/nodereset.go
Outdated
| @@ -79,13 +79,13 @@ func cleanupNetworking() { | |||
| log.Infof("[nodeadm:reset] Removing flannel state files & resetting networking") | |||
| os.RemoveAll(constants.CNIConfigDir) | |||
| os.RemoveAll(constants.CNIStateDir) | |||
| deprecated.RunBestEffort("", "ip", "link", "del", "cni0") | |||
| deprecated.RunBestEffort("", "ip", "link", "del", "flannel.1") | |||
| exec.Command("ip", "link", "del", "cni0").Run() | |||
There was a problem hiding this comment.
Please explicitly ignore the error, i.e., _ := exec.Command(...)
cmd/nodereset.go
Outdated
| @@ -30,7 +30,7 @@ var nodeCmdReset = &cobra.Command{ | |||
|
|
|||
| func kubeadmReset() { | |||
| log.Infof("[nodeadm:reset] Invoking kubeadm reset") | |||
| deprecated.RunBestEffort(constants.BaseInstallDir, "kubeadm", "reset", "--ignore-preflight-errors=all") | |||
| exec.Command(filepath.Join(constants.BaseInstallDir, "kubeadm"), "reset", "--ignore-preflight-errors=all").Run() | |||
There was a problem hiding this comment.
Please explicitly ignore the error
cmd/nodereset.go
Outdated
| deprecated.RunBestEffort("", "ip", "link", "del", "cni0") | ||
| deprecated.RunBestEffort("", "ip", "link", "del", "flannel.1") | ||
| exec.Command("ip", "link", "del", "cni0").Run() | ||
| exec.Command("ip", "link", "del", "flannel.1").Run() |
There was a problem hiding this comment.
Explicitly ignore error
cmd/nodereset.go
Outdated
| } | ||
|
|
||
| func cleanupDockerImages() { | ||
| for _, image := range utils.GetImages() { | ||
| deprecated.RunBestEffort("", "docker", "rmi", "-f", image) | ||
| exec.Command("docker", "rmi", "-f", image).Run() |
There was a problem hiding this comment.
Explicitly ignore error
|
nit: s/pacakge/package in commit message |
ojmhetar
force-pushed
the
private/ojas/remove-deprecated
branch
from
63dc332
to
3beeaed
Compare
sarun87
approved these changes
Nov 6, 2018
vannrt
approved these changes
Nov 6, 2018
puneetguptanitj
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.