-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for two more kubelet flags #80
Conversation
cpu-manager-policy and kube-reserved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, is the customer currently seeing kubelet being cpu starved or is this a preventative measure? Also, why not include a memory
key as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we commit this to a branch, not master? I ask this selfishly, because this will conflict with my 1.11 work. No objections, though.
@ojmhetar thanks for taking a look, right now we want to do just enough to allow |
@dlipovetsky thanks for taking a look, had a chat about this with @sarun87 as well. We were thinking of branching off after @ojmhetar fix for making VIP optional. It would be simpler as both these are required by the customer. As part of 1.11 changes would remove all the custom changes for kubelet config |
I think we should push any non 1.11 changes to master and then branch out to say |
If I understand correctly, this PR would be undone as part of the 1.11 changes (since in 1.11 nodeadm uses kubeadm to pass flags to kubelet). For that reason, I thought it would be easier to omit it from master. But it's not a big deal--go ahead and merge to master. |
Added support for