-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo to allow proper git ssh packages #3624
Conversation
Calling string.split("@",2) does not split into up to two pieces. It splits up to twice, resulting in up to three pieces. This breaks when using a version string that includes a "@" symbol, such as "git@github.com:user/repo.git" in a project's configuration file.
Could you re-test with |
Fixed. It seems the issue was refactored into |
Thanks for the confirmation! The PIO Core 4.4 is planned for release next week. |
@ivankravets I opened up 5.0.0 today, and this issue is still there, in I should have been more precise and stated that the refactor did not fix the issue, and I just tried to fix this pr to change the appropriate file after the refactor. |
Sorry, finally fixed! Please re-test with |
I still seem to have an issue when using a specific branch of the ESP32 Ardunio/ESPIF framework: platform_packages = framework-arduinoespressif32 @ https://github.com/espressif/arduino-esp32.git#idf-release/v4.0 I am running core 5.0.1a1 |
Calling
string.split("@",2)
does not split into up to two pieces. It splits up to twice, resulting in up to three pieces. This breaks when using a package version string that includes a "@" symbol, such asgit@github.com:user/repo.git
in a project's configuration file.