Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create pub when redisd restart #1

Closed

Conversation

atmecs123
Copy link

This code is linked with start() in daemons.go where there is rpc call to the function here in mk1.go which will create new publisher for producing new data into redis.

@tgrennan
Copy link
Contributor

tgrennan commented Feb 5, 2019

This is also the wrong approach. mk1.go should be reworked to retry the pub socket open. Instead of a goroutine as I suggested in the platinasystems/go request, I think we can just try the open in each publish. It won't matter much if we miss counter refreshes while redis is in restart as eventually these will be republished.

@tgrennan tgrennan closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants