Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Elixir CI jobs #3898

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Split Elixir CI jobs #3898

merged 4 commits into from
Mar 18, 2024

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Mar 15, 2024 •
edited
Loading

Changes

This PR attempts to speed up CI by:

  • running MIX_ENV=small_test and MIX_ENV=test test suites in parallel
  • building tracker conditionally (if it's missing or if it has changed)
  • running static checks (format, credo, dialyzer) separately

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga force-pushed the split-elixir-tests branch 3 times, most recently from 0c87dbb to 6425aeb Compare March 15, 2024 02:12
@ruslandoga ruslandoga marked this pull request as ready for review March 15, 2024 03:39
@ruslandoga ruslandoga requested review from a team March 15, 2024 03:39
@ruslandoga ruslandoga changed the title split elixir tests Split Elixir CI jobs Mar 15, 2024
This was referenced Mar 15, 2024
Closed
Merged
Closed
@ruslandoga
Copy link
Contributor Author

ruslandoga commented Mar 15, 2024 •
edited
Loading

Sorry for the rebase... I just wanted to remove unrelated (fix-timezones) changes.

@cnkk
Copy link
Member

cnkk commented Mar 15, 2024

I initially thought about doing static checks before builds, but that would definitely increase the overall run time.

ruslandoga
ruslandoga commented Mar 15, 2024
View reviewed changes
.github/workflows/elixir.yml
mix_env: ['test', 'small_test']
postgres_image: ['postgres:15', 'postgres:16']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now: "Elixir CI / Build and test (small_test, postgres:16) (pull_request)"
Before: "Elixir CI / Build and test (small_test, 16) (pull_request)"

zoldar
zoldar approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@zoldar zoldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@zoldar zoldar merged commit 4ae0054 into master Mar 18, 2024
8 checks passed
@zoldar zoldar deleted the split-elixir-tests branch March 18, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnkk cnkk cnkk approved these changes

@zoldar zoldar zoldar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruslandoga @cnkk @zoldar