Remove dead code under Plausible.Google.HTTP#list_stats #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
drop-dead-referrers-code
branch
2 times, most recently
from
3b2672c
to
f19a3e0
Compare
filters["page"] does not exist currently, meaning all code doesn't get referrer stats for individual pages if filtered so. The fix seems non-trivial since the event:page filter might be e.g. contains or match one of many, so thought it might be best to remove this.
macobo
force-pushed
the
drop-dead-referrers-code
branch
from
f19a3e0
to
a6c292c
Compare
|
Ah, this code was an early attempt to satisfy this feature request which probably worked at some point but got broken as filters format changed. Since this is a fairly highly requested feature I'll play around with the code a bit today to see if I can get it to work again. |
|
Thanks for the context. Let me know how it goes, will be keeping an eye on this as it blocks small part of the filters refactor! |
|
Very much WIP but it's functional and I wanted to share as soon as possible: #4077 Need to finish up:
|
8 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm lacking proper context to evaluate this code, discovered when refactoring filters.
filters["page"]is a typo forfilters["event:page"]. It does not exist currently, meaning all code doesn't get referrer stats for individual pages if filtered so.The fix seems non-trivial since the
event:pagefilter might be e.g. contains or match one of many, so thought it might be best to remove this. Please do share your thoughts if you disagree!