Verification improvements #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- follow up on max. 4 redirects
- rely on Req default timeouts (wait much longer to account for slow
sites)
- rely on Req default timeouts, wait longer - log service errors as warnings - use stealth mode to bypass captchas
zoldar
approved these changes
May 24, 2024
| proxy_likely?: true | ||
| }, | ||
| _url | ||
| ) | ||
| when callback_status != 202 do |
There was a problem hiding this comment.
So the case of callback failing due to other HTTP code will be handled by the final, catch-all clause, right? (like 500/503s, however unlikely).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various integration verification improvements found out during live testing.